-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort versions chronologically #134
Conversation
I think sorting them numerically is nicer than purely alphabetical sort, Ignore my previous concern, I'm not finding the script calls I thought we had on places 🤷 and worst case it should not take much to fix them. |
Regarding ordering by older -> newer instead of newer -> older, I picked this ordering to match how
Also note that
So it would not output the latest version:
This gave me another idea though. It would be really useful for |
Rebased the commit against the latest updates in - for version in get_installable_versions():
+ for version in sorted(get_installable_versions(), key=lambda v: [int(s) for s in v.split(".")]): |
Merged the dev branch, resolved some conflicts, and extracted the sorting logic into its own function. If tests pass I think this would be good to go 👍 thanks for the PR and the patience @ardislu! |
`get_installable_versions()` is already sorted using `Version`
Closes #133